fix(npm): set up node_modules/.bin/ entries for package that provide bin entrypoints #23496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2024
bartlomieju
added a commit
to denoland/eszip
that referenced
this pull request
Apr 23, 2024
Required for denoland/deno#23496.
This was referenced Apr 30, 2024
bartlomieju
changed the title
dsherret
reviewed
May 21, 2024
dsherret
approved these changes
May 23, 2024
| if link.exists() { | ||
| let resolved = std::fs::read_link(&link).ok(); | ||
| if let Some(resolved) = resolved { | ||
| if resolved != original { |
There was a problem hiding this comment.
Can you add to the spec test a step that would cause this codepath to be hit on an already setup node_modules directory?
nathanwhit
force-pushed
the
generate_node_modules_bin_entries
branch
from
560f083
to
123e428
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23036
TODO:
deno_npmandeszip